Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: chore: convert extra checks to github action #5333

Merged
merged 15 commits into from
Jul 11, 2023

Conversation

MartinWitt
Copy link
Collaborator

No description provided.

@MartinWitt
Copy link
Collaborator Author

We should really convert this to a github action.

@MartinWitt MartinWitt changed the title fix: fix parent of spoon decompiler chore: convert extra checks to github action Jul 7, 2023
@MartinWitt MartinWitt changed the title chore: convert extra checks to github action review: chore: convert extra checks to github action Jul 7, 2023
@MartinWitt MartinWitt requested a review from I-Al-Istannen July 7, 2023 21:06
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@@ -48,7 +48,7 @@ jobs:
- uses: oracle-actions/setup-java@2c4df2930e35870536667f383d87f1246fbe613f # v1
with:
website: jdk.java.net
java-version: ${{ matrix.java }}
version: ${{ matrix.java }}
Copy link
Collaborator Author

@MartinWitt MartinWitt Jul 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The oracle action uses version and not java-version. https://github.com/oracle-actions/setup-java

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay lets fix this in another PR.

Copy link
Collaborator

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great improvement to the CI. I have a few things that could be considered to further improve it (probably here, probably in separate PRs):

  1. Most steps don't depend on each other. What do you think about having separate jobs for them?
  2. We download some files (the z3 build, gradle). Can we make use of caching?
  3. It seems like most sub projects run similar maven commands, however, it's somewhat inconsistent (some run depclean, some run checkstyle, some run both). Is this something we want to improve?

@MartinWitt
Copy link
Collaborator Author

I think this is a great improvement to the CI. I have a few things that could be considered to further improve it (probably here, probably in separate PRs):

  1. Most steps don't depend on each other. What do you think about having separate jobs for them?

Actually, most jobs need to install spoon-core/spoon-pom before. We dont want to run mvn install to often, as this takes time.

  1. We download some files (the z3 build, gradle). Can we make use of caching?

Sure

  1. It seems like most sub projects run similar maven commands, however, it's somewhat inconsistent (some run depclean, some run checkstyle, some run both). Is this something we want to improve?

I hope there is some reasoning behind this

@MartinWitt
Copy link
Collaborator Author

The z3 download is cached now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants