-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
review: chore: convert extra checks to github action #5333
Conversation
We should really convert this to a github action. |
.github/workflows/tests.yml
Outdated
@@ -48,7 +48,7 @@ jobs: | |||
- uses: oracle-actions/setup-java@2c4df2930e35870536667f383d87f1246fbe613f # v1 | |||
with: | |||
website: jdk.java.net | |||
java-version: ${{ matrix.java }} | |||
version: ${{ matrix.java }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The oracle action uses version and not java-version. https://github.com/oracle-actions/setup-java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay lets fix this in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great improvement to the CI. I have a few things that could be considered to further improve it (probably here, probably in separate PRs):
- Most steps don't depend on each other. What do you think about having separate jobs for them?
- We download some files (the z3 build, gradle). Can we make use of caching?
- It seems like most sub projects run similar maven commands, however, it's somewhat inconsistent (some run depclean, some run checkstyle, some run both). Is this something we want to improve?
Actually, most jobs need to install spoon-core/spoon-pom before. We dont want to run
Sure
I hope there is some reasoning behind this |
The z3 download is cached now. |
No description provided.