-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update jetbrains/qodana-action action to v2023 #5195
Conversation
This requires atleast an update of the linter in our qodana.yml file. But also the config format was improved. I will push a fix for this dependency with the new config soon. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Looks like our old config still works. I prefer to not touch it if it works. If you want to have a look at the changelogs, see https://blog.jetbrains.com/qodana/2023/04/qodana-2023-1/#FlexibleprofileconfigurationwiththenewYAMLformat |
Do we need to specify the linter explicitly in the qodana.yaml? How does that differ from the action? |
There was an warning message written if you don't specific your linter that you should setup Qodana with |
Hm, that doesn't sound great either, but if it works and we don't need to manually update the version ourselves, it might be a bit better. |
I removed the linter. Lets give it a try? |
|
https://youtrack.jetbrains.com/issue/QD-4217/No-valid-qodana.yaml-found-even-though-it-is-present as you see here it is only a warning. |
Setting to latest means we will update the qodana linter silently if there is any update. This seems not ideal for a CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let's go this way then.
This PR contains the following updates:
v2022.3.4
->v2023.1.0
⚠ Dependency Lookup Warnings ⚠
Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.
Release Notes
JetBrains/qodana-action
v2023.1.0
Compare Source
Changelog
5e14015
⬆️ Bump xml2js, @azure/ms-rest-js and @azure/storage-blobddd70ab
🚸 Improve GitHub action summarybdbf6e5
⚡ Updateqodana
to2023.1.0
9f2af3f
⚡ Allow setting cache keys on GitHub and CircleCI (#107)61b94e7
⚡ Add licenses preview to job outputConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.