Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update jetbrains/qodana-action action to v2023 #5195

Merged
merged 3 commits into from
May 12, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 27, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
JetBrains/qodana-action action major v2022.3.4 -> v2023.1.0

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.


Release Notes

JetBrains/qodana-action

v2023.1.0

Compare Source

Changelog


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@MartinWitt
Copy link
Collaborator

This requires atleast an update of the linter in our qodana.yml file. But also the config format was improved. I will push a fix for this dependency with the new config soon.

@MartinWitt MartinWitt mentioned this pull request May 3, 2023
10 tasks
@renovate
Copy link
Contributor Author

renovate bot commented May 7, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@MartinWitt
Copy link
Collaborator

MartinWitt commented May 7, 2023

Looks like our old config still works. I prefer to not touch it if it works. If you want to have a look at the changelogs, see https://blog.jetbrains.com/qodana/2023/04/qodana-2023-1/#FlexibleprofileconfigurationwiththenewYAMLformat

@MartinWitt MartinWitt requested a review from SirYwell May 7, 2023 20:03
@SirYwell
Copy link
Collaborator

Do we need to specify the linter explicitly in the qodana.yaml? How does that differ from the action?

@MartinWitt
Copy link
Collaborator

Do we need to specify the linter explicitly in the qodana.yaml? How does that differ from the action?

There was an warning message written if you don't specific your linter that you should setup Qodana with qodana init. We can accept this message and remove the linter in qodana.yml if you want.

@SirYwell
Copy link
Collaborator

Do we need to specify the linter explicitly in the qodana.yaml? How does that differ from the action?

There was an warning message written if you don't specific your linter that you should setup Qodana with qodana init. We can accept this message and remove the linter in qodana.yml if you want.

Hm, that doesn't sound great either, but if it works and we don't need to manually update the version ourselves, it might be a bit better.

@MartinWitt
Copy link
Collaborator

Do we need to specify the linter explicitly in the qodana.yaml? How does that differ from the action?

There was an warning message written if you don't specific your linter that you should setup Qodana with qodana init. We can accept this message and remove the linter in qodana.yml if you want.

Hm, that doesn't sound great either, but if it works and we don't need to manually update the version ourselves, it might be a bit better.

I removed the linter. Lets give it a try?

@I-Al-Istannen
Copy link
Collaborator

! No valid qodana.yaml found. Have you run qodana init? Running that for you...
Seems like the file is no longer valid. Have you tried setting the linter version to latest?

@MartinWitt
Copy link
Collaborator

@MartinWitt
Copy link
Collaborator

! No valid qodana.yaml found. Have you run qodana init? Running that for you... Seems like the file is no longer valid. Have you tried setting the linter version to latest?

Setting to latest means we will update the qodana linter silently if there is any update. This seems not ideal for a CI?

Copy link
Collaborator

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's go this way then.

@SirYwell SirYwell merged commit e14e6b5 into master May 12, 2023
@SirYwell SirYwell deleted the renovate/jetbrains-qodana-action-2023.x branch May 12, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants