test: Add tests for comment association #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-Al-Istannen
requested changes
Apr 10, 2023
|
Also paging @SirYwell because I think he has thrown himself off that cliff before :) |
I-Al-Istannen
approved these changes
Apr 10, 2023
SirYwell
approved these changes
Apr 13, 2023
I-Al-Istannen
changed the title
|
Thanks @Zuplyx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created failing UnitTests for some of the issues with comment association reported in the linked issue.
The tests demonstrate the following issues:
CtArrayAccessandCtBinaryOperatorelements are not added to the AST.CtTypeParameterelements are either wrongly added to the class (comments 1 and 4) or not added to the AST at all (comments 2 and 3).CtAnnotationelements are not added to the annotation, but instead to theCtLiteralparameter of the annotation.