review: chore(CI): bump java ea version to 21 #5143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe they will add 21-ea builds after 20 is published. |
|
Maybe we can go from 19 to 20 in this PR too? |
|
Sure I will update this pr
Hannes Greule ***@***.***> schrieb am Mo., 20. März 2023,
08:13:
… Maybe we can go from 19 to 20 in this PR too?
—
Reply to this email directly, view it on GitHub
<#5143 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGBA5HYJM3DA5NXECPJ2FQTW477QPANCNFSM6AAAAAAWABPUYY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I am not 100% happy with changing to the oracle setup-java action, but the current setup-java action simply does not have early access builds for jdk-20. The oracle actions uses setup-java by itself, so there shouldn't be any large changes for us. |
MartinWitt
changed the title
SirYwell
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As java 20 is released at 21.03 we can start using the 21-ea builds in our CI.