review: fix: set correct executable reference type for signature polymorphic methods #4915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SirYwell
force-pushed
the
fix/signature-polymorphic-methods
branch
from
40a850b to
6b0190b
Compare
SirYwell
changed the title
|
Let the review begin :) |
Co-authored-by: I-Al-Istannen <[email protected]>
I-Al-Istannen
approved these changes
May 24, 2023
|
thanks a lot @SirYwell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4863
As we decided to go the easier route, the change is pretty straightforward: We only need to correct the return type of the reference to always be
java.lang.Object.