fix: print square brackets for manually created array references #4888
Conversation
|
@I-Al-Istannen can you please review this? |
|
|
||
|
|
||
| // act | ||
| ((CtArrayTypeReferenceImpl<?>) arrayTypeReference).setDeclarationKind(CtArrayTypeReferenceImpl.DeclarationKind.IDENTIFIER); |
There was a problem hiding this comment.
These explicit casts look ugly. I can move the APIs used in the CtArrayTypeReference interface. I do not know why I did not implement it that way in #4341 . If the reviewers think this is a good idea, I can submit a separate PR for this.
There was a problem hiding this comment.
I think "hiding" that functionality makes sense - we probably shouldn't encourage people to make use of it. Otherwise you'd also need to add support for it on return types, i.e. public int method()[] { return new int[10]; } 😉
There was a problem hiding this comment.
Additionally, I am not sure how much value this offers as attaching the brackets to the name (or after the method...) is not a really common style from what I have gathered.
There was a problem hiding this comment.
public int method()[] { return new int[10]; }
Wow. I did not know that is a valid syntax. Maybe we can add support for it if someone ever reports a bug. However, it is so unlikely people shall use this syntax which is good :)
Additionally, I am not sure how much value this offers as attaching the brackets to the name (or after the method...) is not a really common style from what I have gathered.
Right. It does not seem useful from a transformation perspective so we can keep it as is.
src/test/java/spoon/reflect/visitor/DefaultJavaPrettyPrinterTest.java
Outdated
Show resolved
Hide resolved
algomaster99
requested review from
I-Al-Istannen and
SirYwell
and removed request for
I-Al-Istannen and
SirYwell
I-Al-Istannen
changed the title
|
Thanks :) |
Fixes #4887
The changes modify the constructor of
CtArrayTypeReferenceImplto set the declaration style asTYPEby default.