feat: Use inferred generic type in invocations #4844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no explicit type arguments are given, the type arguments JDT inferred are now used for getActualTypeArguments.
I-Al-Istannen
changed the title
SirYwell
reviewed
Aug 18, 2022
There was a problem hiding this comment.
I think it makes sense to use the information in the model. While it makes the printer a bit more complex, it helps with analysing code. I think we should look into more places where we don't use implicit information.
For the PrintTypeArguments I'd prefer to either find better suited names or document it properly. It also looks like the writeActualTyoeArguments() method is public, so I'm not sure if we can just add a parameter to it.
src/main/java/spoon/reflect/visitor/DefaultJavaPrettyPrinter.java
Outdated
Show resolved
Hide resolved
|
I overloaded it, so existing callers and subclasses should be fine. I also renamed them and added some documentation, maybe that's nicer now? |
MartinWitt
changed the title
|
Thanks @I-Al-Istannen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no explicit type arguments are given, the type arguments JDT inferred are now used for getActualTypeArguments.
This addresses
#4834#4838, but I am not sure we actually want to use the inferred information. It seems quite useful, but it may also be incomplete if JDT is not able to infer things correctly.