review: Use official qodana github action #4843

MartinWitt · 2022-08-15T06:51:43Z

Like ever enterprise project, the developers make horrible decisions at someday and remove the usability.
The Qodana action no longer supports the options we gave it. We need to provide these options as a single string. This is a result of the change in the action using Qodana CLI. Qodana only gave a warning in the log for this behavior, and the last runs since this change could have produced wrong results.
Maybe someone with more advanced YAML skills has a solution for this hideous long string?

… changing-tarantula

slarse · 2022-08-20T08:28:29Z

.github/workflows/tests.yml

-      - uses: github/codeql-action/upload-sarif@3f62b754e23e0dd60f91b744033e1dc1654c0ec6 # tag=v2
+      - uses: github/codeql-action/upload-sarif@v2


Don't remove the commit pins. Pinning on tag is not safe as they can move. But most prominently it leads to unexpected failures when devs introduce breaking changes and move tags to those.

.github/workflows/tests.yml

slarse · 2022-08-20T08:44:02Z

src/main/java/spoon/support/compiler/ZipFolder.java

+		if (false==true) {
+			String s = new String[0].toString();
+		}


Guessing this is just to trigger an error?

Co-authored-by: Simon Larsén <[email protected]>

… changing-tarantula

sonatype-lift · 2022-10-30T16:28:12Z

src/main/java/spoon/support/compiler/ZipFolder.java

@@ -49,6 +49,9 @@ public ZipFolder(File file) throws IOException {
 		}
 		this.file = file;
 	}
+	private Object deleteMe() {


UnusedMethod: Method 'deleteMe' is never used.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

- Remove deprecated cli options. - set to strict mode failing if more then zero issues are found.

MartinWitt · 2022-10-31T21:28:38Z

This ports Qodana to the new style. We fail the CI if any problems are found. If we see this is too strict, we can disable it.

I-Al-Istannen · 2022-11-07T11:21:01Z

I'd be happy to merge if you could quickly test whether it really fails the check. There were significant changes since the last time this was tested in this PR, if I did not miss anything.

slarse · 2022-11-18T19:20:16Z

@MartinWitt ☝️ conflict :o

I've been incredibly busy with other things for the past couple of weeks and feel a bit out of the loop, is there anything keeping us from merging this (except for the conflict)?

I-Al-Istannen · 2022-11-19T23:28:15Z

I've been incredibly busy with other things for the past couple of weeks and feel a bit out of the loop, is there anything keeping us from merging this (except for the conflict)?

Your guess is as good as mine, but I don't think so. I would really love to get this merged though, as the current pinned hash is now expired and qodana runs fail with:

This IDE build has expired. Please download a new build from JetBrains official site
✗  Qodana exited with code 7

See https://github.com/INRIA/spoon/actions/runs/3505578524/jobs/5871965639.

MartinWitt · 2022-11-20T09:04:43Z

I fixed the conflict. Shall I push some bad to showcase Qodana is working?

I-Al-Istannen · 2022-11-20T09:48:29Z

I fixed the conflict. Shall I push some bad to showcase Qodana is working?

I'd appreciate it :)

MartinWitt · 2022-11-20T10:06:11Z

@I-Al-Istannen CI is red as wanted.

I-Al-Istannen · 2022-11-20T10:07:29Z

Looks good to me :)

This reverts commit b3f2b96.

src/main/java/spoon/support/StandardEnvironment.java

slarse · 2022-11-20T10:47:21Z

Looks like CI extra checks are failing as snapshots can't be fetched from OW2 repository :/

I-Al-Istannen · 2022-11-20T22:30:48Z

@slarse Fixed now, I think you can review/merge it. Your negative review is greying out the merge button — though I might be able to overrule you.

slarse · 2022-11-21T11:33:34Z

@I-Al-Istannen I'd be more comfortable if you merged as you were the last to look at it, I've approved so there shouldn't be any problems now.

I-Al-Istannen · 2022-11-21T12:54:36Z

I'd be more comfortable if you merged as you were the last to look at it, I've approved so there shouldn't be any problems now.

A wise decision, as qodana now failed on master :)

EDIT: Looking into github actions and the results here a bit more and checking with #4748, it seems to perform delta checks on PRs and full tests on master. So we probably just need to disable it on master and things should be alright. Neat.

slarse · 2022-11-21T19:10:04Z

A wise decision, as qodana now failed on master :)

Jackpot.

change qodana options to match new style

b6e3a8e

MartinWitt changed the title ~~change qodana options to match new style~~ chore: change qodana options to match new style Aug 15, 2022

MartinWitt added 7 commits August 15, 2022 08:56

Update tests.yml

dc27d77

Update tests.yml

3f49933

up

1d2af6a

Merge branch 'changing-tarantula' of github.com:MartinWitt/spoon into…

6a08a47

… changing-tarantula

qodana test

97f98a7

Update tests.yml

3e150e8

Update tests.yml

c6e86d0

slarse suggested changes Aug 20, 2022

View reviewed changes

MartinWitt and others added 9 commits September 25, 2022 11:58

Update .github/workflows/tests.yml

ffa956a

Co-authored-by: Simon Larsén <[email protected]>

Update tests.yml

c4a8af6

Merge branch 'master' into changing-tarantula

e9d838f

Update tests.yml

be160cd

Update ZipFolder.java

9c6e284

test qodana

3c08c4e

Merge branch 'master' into changing-tarantula

bdd58c6

up

1b0b4a4

Merge branch 'changing-tarantula' of github.com:MartinWitt/spoon into…

211316f

… changing-tarantula

sonatype-lift bot reviewed Oct 30, 2022

View reviewed changes

up

2a4fd6e

MartinWitt changed the title ~~chore: change qodana options to match new style~~ wip: chore: change qodana options to match new style Oct 30, 2022

refactor qodana action to new style.

179aa3f

- Remove deprecated cli options. - set to strict mode failing if more then zero issues are found.

MartinWitt force-pushed the changing-tarantula branch from 94a0e7d to 179aa3f Compare October 31, 2022 21:22

MartinWitt changed the title ~~wip: chore: change qodana options to match new style~~ review: chore: change qodana options to match new style Oct 31, 2022

MartinWitt requested review from I-Al-Istannen and SirYwell November 6, 2022 18:31

Merge branch 'master' into changing-tarantula

43586ce

💩 add code to showcase qodana works

b3f2b96

Revert "💩 add code to showcase qodana works"

e053a5b

This reverts commit b3f2b96.

sonatype-lift bot reviewed Nov 20, 2022

View reviewed changes

src/main/java/spoon/support/StandardEnvironment.java Outdated Show resolved Hide resolved

I-Al-Istannen approved these changes Nov 20, 2022

View reviewed changes

slarse approved these changes Nov 21, 2022

View reviewed changes

I-Al-Istannen changed the title ~~review: chore: change qodana options to match new style~~ review: Use official qodana github action Nov 21, 2022

I-Al-Istannen merged commit d753cba into INRIA:master Nov 21, 2022

I-Al-Istannen deleted the changing-tarantula branch November 21, 2022 12:41

MartinWitt mentioned this pull request Nov 21, 2022

fix: use Qodana for PRs only #5020

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

review: Use official qodana github action #4843

review: Use official qodana github action #4843

MartinWitt commented Aug 15, 2022 •

edited

Loading

slarse Aug 20, 2022

slarse Aug 20, 2022

MartinWitt Aug 20, 2022

sonatype-lift bot Oct 30, 2022

MartinWitt commented Oct 31, 2022

I-Al-Istannen commented Nov 7, 2022

slarse commented Nov 18, 2022

I-Al-Istannen commented Nov 19, 2022

MartinWitt commented Nov 20, 2022

I-Al-Istannen commented Nov 20, 2022

MartinWitt commented Nov 20, 2022

I-Al-Istannen commented Nov 20, 2022

slarse commented Nov 20, 2022

I-Al-Istannen commented Nov 20, 2022

slarse commented Nov 21, 2022

I-Al-Istannen commented Nov 21, 2022 •

edited

Loading

slarse commented Nov 21, 2022

		- uses: github/codeql-action/upload-sarif@3f62b754e23e0dd60f91b744033e1dc1654c0ec6 # tag=v2
		- uses: github/codeql-action/upload-sarif@v2

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

review: Use official qodana github action #4843

review: Use official qodana github action #4843

Conversation

MartinWitt commented Aug 15, 2022 • edited Loading

slarse Aug 20, 2022

Choose a reason for hiding this comment

slarse Aug 20, 2022

Choose a reason for hiding this comment

MartinWitt Aug 20, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 30, 2022

Choose a reason for hiding this comment

MartinWitt commented Oct 31, 2022

I-Al-Istannen commented Nov 7, 2022

slarse commented Nov 18, 2022

I-Al-Istannen commented Nov 19, 2022

MartinWitt commented Nov 20, 2022

I-Al-Istannen commented Nov 20, 2022

MartinWitt commented Nov 20, 2022

I-Al-Istannen commented Nov 20, 2022

slarse commented Nov 20, 2022

I-Al-Istannen commented Nov 20, 2022

slarse commented Nov 21, 2022

I-Al-Istannen commented Nov 21, 2022 • edited Loading

slarse commented Nov 21, 2022

MartinWitt commented Aug 15, 2022 •

edited

Loading

I-Al-Istannen commented Nov 21, 2022 •

edited

Loading