Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: fix: handle null bodies of while statements. #4813

Merged
merged 2 commits into from
Aug 6, 2022
Merged

review: fix: handle null bodies of while statements. #4813

merged 2 commits into from
Aug 6, 2022

Conversation

MartinWitt
Copy link
Collaborator

fixes #4803.
Tbh it is just a band-aid fix because I have zero clue about the ControlFlowBuilder.

@MartinWitt MartinWitt changed the title fix: handle null bodies of while statements. review: fix: handle null bodies of while statements. Jul 26, 2022
slarse
slarse approved these changes Aug 6, 2022
View reviewed changes
Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have little insight here but this is at the very least better than crashing.

@slarse slarse merged commit 51142ec into INRIA:master Aug 6, 2022
@slarse
Copy link
Collaborator

slarse commented Aug 6, 2022

Thanks @MartinWitt

@monperrus monperrus mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarse slarse slarse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: ControlFlowBuilder throws NullPointerException due to empty while loop body
2 participants
@MartinWitt @slarse