Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: fix: set source position of type pattern #4755

Merged
merged 3 commits into from
Jun 23, 2022
Merged

review: fix: set source position of type pattern #4755

merged 3 commits into from
Jun 23, 2022

Conversation

SirYwell
Copy link
Collaborator

Fixes #4723.

As the CtTypePattern instance basically only wraps the CtLocalVariable, we should also use its SourcePosition.

@SirYwell SirYwell changed the title wip: fix: set source position of type pattern review: fix: set source position of type pattern Jun 22, 2022
@SirYwell SirYwell marked this pull request as ready for review June 22, 2022 20:06
slarse
slarse approved these changes Jun 23, 2022
View reviewed changes
Copy link
Collaborator

@slarse slarse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, good catch. Will merge.

@slarse slarse merged commit 319f456 into INRIA:master Jun 23, 2022
@slarse
Copy link
Collaborator

slarse commented Jun 23, 2022

Thanks @SirYwell !

@SirYwell SirYwell deleted the fix/type-pattern-position branch June 23, 2022 20:29
@monperrus monperrus mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarse slarse slarse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Exception when using sniper prettyprint with instanceof pattern matching
2 participants
@SirYwell @slarse