review: fix: Stop adding duplicated modules when cloning them #4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-Al-Istannen
changed the title
I-Al-Istannen
changed the title
I-Al-Istannen
force-pushed
the
fix/module-printing-duplicates
branch
from
41c4feb to
86883b4
Compare
Previously, cloning a module (e.g. while printing it), caused the module to be inserted in to the global list of modules *again*. Co-authored-by: Hannes Greule <[email protected]>
I-Al-Istannen
force-pushed
the
fix/module-printing-duplicates
branch
from
86883b4 to
df1a623
Compare
slarse
approved these changes
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was discovered while trying to reproduce #4746. Printing a module caused it to be cloned, leading to a duplicate insertion into the global module list. This in turn triggered the "overlapping modules found" sanity check (thankfully!).