Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add for-loop elements to UnsupportedElementSwapper and add warning messages (issue #4716) #4720

Merged
merged 4 commits into from
May 4, 2022

Conversation

mkforsb
Copy link
Contributor

@mkforsb mkforsb commented May 1, 2022

This adds CtFor and CtForEach to the set of elements swapped out by spoon-smpl's UnsupportedElementSwapper along with a warning log message for each replaced element.

Should be a slight improvement on the current user experience (see #4716).

@monperrus
Copy link
Collaborator

@mkforsb Would we able to add a test case to specify this behavior?

@mkforsb
Copy link
Contributor Author

mkforsb commented May 1, 2022

@mkforsb Would we able to add a test case to specify this behavior?

Two simple tests added.

@MartinWitt
Copy link
Collaborator

Could you document the current implementation state inside the subproject? Missing elements are a factory when you choose your tool, and we should be as honest as possible about the limitations.

@monperrus monperrus merged commit 53e90e7 into INRIA:master May 4, 2022
@monperrus
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants