Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate ExecutableRefTest to JUnit 5 #4518

Merged

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in methodTest
  • Replaced junit 4 test annotation with junit 5 test annotation in constructorTest
  • Replaced junit 4 test annotation with junit 5 test annotation in testGetActualClassTest
  • Replaced junit 4 test annotation with junit 5 test annotation in testSameTypeInConstructorCallBetweenItsObjectAndItsExecutable
  • Replaced junit 4 test annotation with junit 5 test annotation in testOverridingMethod

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in methodTest
  • Transformed junit4 assert to junit 5 assertion in constructorTest
  • Transformed junit4 assert to junit 5 assertion in testGetActualClassTest
  • Transformed junit4 assert to junit 5 assertion in testSameTypeInConstructorCallBetweenItsObjectAndItsExecutable
  • Transformed junit4 assert to junit 5 assertion in getInvocationFromMethod
  • Transformed junit4 assert to junit 5 assertion in testOverridingMethod

 The following has changed in the code:
Replaced junit 4 test annotation with junit 5 test annotation in methodTest
Replaced junit 4 test annotation with junit 5 test annotation in constructorTest
Replaced junit 4 test annotation with junit 5 test annotation in testGetActualClassTest
Replaced junit 4 test annotation with junit 5 test annotation in testSameTypeInConstructorCallBetweenItsObjectAndItsExecutable
Replaced junit 4 test annotation with junit 5 test annotation in testOverridingMethod
Transformed junit4 assert to junit 5 assertion in methodTest
Transformed junit4 assert to junit 5 assertion in constructorTest
Transformed junit4 assert to junit 5 assertion in testGetActualClassTest
Transformed junit4 assert to junit 5 assertion in testSameTypeInConstructorCallBetweenItsObjectAndItsExecutable
Transformed junit4 assert to junit 5 assertion in getInvocationFromMethod
Transformed junit4 assert to junit 5 assertion in testOverridingMethod
@monperrus monperrus merged commit 52f8c96 into INRIA:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants