fix: print necessary parentheses when accessing a new array directly #4239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWitt
approved these changes
Oct 19, 2021
SirYwell
changed the title
monperrus
reviewed
Oct 20, 2021
| CtModel model = SpoonTestHelpers.createModelFromString(code, 8); | ||
| CtType<?> first = model.getAllTypes().iterator().next(); | ||
| assertThat(first.toString(), containsString(line)); | ||
| CtCodeSnippetStatement statement = launcher.getFactory().createCodeSnippetStatement(line); |
There was a problem hiding this comment.
if you pretty-print a CtCodeSnippetStatement, it's the input line, so the assert is useless. you have to call compile first to transform the CtCodeSnippetStatement into an AST
There was a problem hiding this comment.
Oh yeah, that wasn't meant to end up there. Thanks for catching it.
|
LGTM, needs to fix conflicts |
SirYwell
force-pushed
the
fix/new-array-access
branch
from
b3adc93 to
83a66e5
Compare
|
Rebased (and removed unused code I added before) |
monperrus
changed the title
|
Cool, nice Friday contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a statement like
int a = (new int[10])[1];was printed likeint a = new int[10][1];. This won't compile anymore as the types aren't compatible.While I hope I'll never come across such code anywhere, I thought it would be worth to fix it.