Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: fix: Recognize local type references with numbers in the name #4212

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

SirYwell
Copy link
Collaborator

@SirYwell SirYwell commented Oct 7, 2021

The previous regex did not match names with digits in it in places where the JLS allows it.

This is a follow up of #4211.

@SirYwell SirYwell changed the title wip: fix: Recognize local type references with numbers in the name review: fix: Recognize local type references with numbers in the name Oct 7, 2021
@monperrus
Copy link
Collaborator

monperrus commented Oct 8, 2021

Nice! Can we test for isLocalType == false also?

@SirYwell
Copy link
Collaborator Author

SirYwell commented Oct 9, 2021

Can we test for isLocalType == false also?

Done.

Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @SirYwell

@slarse slarse merged commit 67e443d into INRIA:master Oct 11, 2021
@SirYwell SirYwell deleted the fix/local-type-ref branch October 11, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants