review: Fix implicit modifiers for nested interface member types #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-Al-Istannen
changed the title
I-Al-Istannen
changed the title
The latter doesn't adhere to the normal conventions but already existed. I missed it when writing my own tests.
I-Al-Istannen
changed the title
|
Nice, LGTM. |
slarse
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
LGTM as well so I'll go ahead and merge :)
Thanks @I-Al-Istannen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #4038.
Nested types in interfaces should be implicitly
public static.