chore: Add tag pinning to GHA digest update #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
monperrus
changed the title
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4046 (comment)
Currently, Renovate is updating the SHA digests of GitHub Actions to the latest one on the primary branch, but we only want stable releases. Based on the docs over here, I think that this PR should fix that problem.
I'm not entirely sure, as the docs are a little bit ambiguous, and there's a possibility that they mean that they'll just stick to that specific tag and update the digest if the tag is updated, but not update to later tags. If that's the case, then we should specify
tag=vX(only the major version) for each action, as that tag is by GHA conventions moved to the latest iteration of that major version each time there's a new release.