review: fix: Fix the insertion order for CtStatementListImpl.insertBegin #4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rohitesh-Kumar-Jain
changed the title
Rohitesh-Kumar-Jain
changed the title
slarse
approved these changes
Aug 10, 2021
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:#4060
#4060
In #4063, I fixed
CtCaseImpl.insertBegin, this PR aims to fixCtStatementListImpl.insertBegin. They have a similar bug and a similar fix, so I thought it's best to fix them simultaneously, so that we are able to close #4060 in concrete terms.Also, this test is killing this mutation
link to #3967