review: fix: get correct descriptions from CtJavaDocImpl #4061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tains a qualified name
slarse
suggested changes
Aug 9, 2021
There was a problem hiding this comment.
@andrewbwogi thanks for the PR, could you have a look at my comment?
Comment on lines
89
to
93
| while (this.getContent().length() > indexEndSentence + 1 | ||
| && !Character.isWhitespace(this.getContent().charAt(indexEndSentence + 1)) | ||
| && indexEndSentence != -1) { | ||
| indexEndSentence = this.getContent().indexOf('.', indexEndSentence + 1); | ||
| } |
There was a problem hiding this comment.
This looks rather complicated to me. Could you extract searching for the end-sentence index to a separate method (something like int indexOfFirstSentenceEnd(String content))?
Also, in comparisons, I'd strongly recommend putting the "dynamic" element (the value that changes) on the left, and only that. For example:
// not ideal IMO, as the key variable of the comparison is on the right (less evident)
// and part of a subexpression (+)
this.getContent().length() > indexEndSentence + 1
// better, they key variable is now on the left (immediately catches the eye) and stands on its own
indexEndSentence < this.getContent().length() - 1I'd argue that's the standard for out-of-bounds checks at least.
There was a problem hiding this comment.
Thanks @slarse, a new commit coming up.
|
ping @andrewbwogi to complete this one? |
|
Thanks @andrewbwogi, that's nice and easy to read! |
slarse
approved these changes
Aug 10, 2021
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4059