Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: test: add tests for CtCommentIMmpl class #4053

Merged
merged 7 commits into from
Jul 26, 2021
Merged

review: test: add tests for CtCommentIMmpl class #4053

merged 7 commits into from
Jul 26, 2021

Conversation

Rohitesh-Kumar-Jain
Copy link
Contributor

#1818

Hi, I have added some new tests for methods of the JavaOutputProcessor class :

These tests are intended to kill this mutation:

Screenshot 2021-07-18 at 3 02 08 PM

Link to #3967

Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Rohitesh-Kumar-Jain,

The test intents are good, but they can be made significantly shorter and even more clear with some slight tweaks.

src/test/java/spoon/test/comment/CommentTest.java Outdated Show resolved Hide resolved
src/test/java/spoon/test/comment/CommentTest.java Outdated Show resolved Hide resolved
src/test/java/spoon/test/comment/CommentTest.java Outdated Show resolved Hide resolved
src/test/java/spoon/test/comment/CommentTest.java Outdated Show resolved Hide resolved
src/test/java/spoon/test/comment/CommentTest.java Outdated Show resolved Hide resolved
src/test/java/spoon/test/comment/CommentTest.java Outdated Show resolved Hide resolved
src/test/java/spoon/test/comment/CommentTest.java Outdated Show resolved Hide resolved
@Rohitesh-Kumar-Jain
Copy link
Contributor Author

Rohitesh-Kumar-Jain commented Jul 21, 2021

Other methods in this class don't need improvement in tests so, there's no hurry to merge this one

ps: I have no more commits form my side to push

Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Rohitesh-Kumar-Jain

@slarse slarse merged commit 909b7c5 into INRIA:master Jul 26, 2021
@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain deleted the add-tests-for-ctCommentImpl branch July 26, 2021 08:59
@monperrus monperrus mentioned this pull request Aug 19, 2021
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants