review: fix(test): error output for CtInheritanceScanner test prints wrong class name #4037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on my other pull request, I came about this confusing output:
I wondered why it would expect me to add this method to the CtScanner as there are no other methods like that. Looking closer at the test revealed that the method is expected in CtInheritanceScanner instead. This PR uses the simple class name instead, so
CtInheritanceScanner
is now printed correctly.It also seems like the CtScanner is not required as input resource. I guess that is a leftover from when this test was implemented.
Note: I'm not sure about this, but it the test case itself is probably named badly, indicating that it is about the CtScanner instead of the CtInheritanceScanner. If you agree on this, I can change the name of the test case too.