Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: fix(test): error output for CtInheritanceScanner test prints wrong class name #4037

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

SirYwell
Copy link
Collaborator

When working on my other pull request, I came about this confusing output:

[ERROR] Failures: 
[ERROR]   SpoonArchitectureEnforcerTest.testInterfacesAreCtScannable:358 The following methods are missing in CtScanner: 
scanCtPattern

I wondered why it would expect me to add this method to the CtScanner as there are no other methods like that. Looking closer at the test revealed that the method is expected in CtInheritanceScanner instead. This PR uses the simple class name instead, so CtInheritanceScanner is now printed correctly.

It also seems like the CtScanner is not required as input resource. I guess that is a leftover from when this test was implemented.

Note: I'm not sure about this, but it the test case itself is probably named badly, indicating that it is about the CtScanner instead of the CtInheritanceScanner. If you agree on this, I can change the name of the test case too.

Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find @SirYwell. Will merge.

@slarse slarse merged commit 8fdebb3 into INRIA:master Jul 13, 2021
@monperrus monperrus mentioned this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants