Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reveiw: test: add test for Substituion.insertAllSuperInterfaces #4012

Merged
merged 2 commits into from
Jun 29, 2021
Merged

reveiw: test: add test for Substituion.insertAllSuperInterfaces #4012

merged 2 commits into from
Jun 29, 2021

Conversation

Rohitesh-Kumar-Jain
Copy link
Contributor

#1818

Hi, I have added a new test for insertAllSuperInterfaces method of the Substitution class, following are the features of this test:

  1. The test kills this mutation

Screenshot 2021-06-28 at 2 20 29 PM

  1. It is killing this mutation as well

Screenshot 2021-06-28 at 2 21 23 PM

Link to #3967

Verified

This commit was signed with the committer’s verified signature.
phodal Fengda Huang
Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test LGTM, but there's some duplication in the tests that we might want to address. Have a look at my comment.

src/test/java/spoon/test/template/SubstitutionTest.java Outdated Show resolved Hide resolved
Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge!

@slarse slarse merged commit 5233ffc into INRIA:master Jun 29, 2021
@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain deleted the add-test-for-substituion-insertAllSuperInterfaces branch June 29, 2021 09:37
@monperrus monperrus mentioned this pull request Aug 19, 2021
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants