Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review : test: Migrate all refactoring tests to Junit5 #4007

Merged
merged 2 commits into from
Jun 28, 2021
Merged

review : test: Migrate all refactoring tests to Junit5 #4007

merged 2 commits into from
Jun 28, 2021

Conversation

Rohitesh-Kumar-Jain
Copy link
Contributor

#3919

Hi, this PR involves pure refactoring.

I will be working on spoon.refactoring next hence raised the PR for migration.

Screenshot 2021-06-27 at 10 34 57 AM

This PR just involves these two types of changes:

  1. changing imports

  2. In some assertions due to the Junit5 rules, the order of the parameters changed with the output message parameter moved as the last parameter.

link to #3967

Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice!

@slarse slarse merged commit de43822 into INRIA:master Jun 28, 2021
@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain deleted the migrate-refactoring-tests-to-junit5 branch June 28, 2021 07:32
@monperrus monperrus mentioned this pull request Aug 19, 2021
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants