review: test: add test for SubstituionInsertAllNestedTypes

[Rohitesh-Kumar-Jain]

#1818

Hi, I have added a new test for insertAllNestedFilelds method of the Substitution class, this test improves code coverage, mutation converge and test strength all from 0% to 100%.

Here's the report before improvement.

The exception added in this test, is able to kill the mutation but, probably isn't the strongest assertion, I wan't able to make it stronger.

[Rohitesh-Kumar-Jain]

Link to #3967

[slarse]

Looks good, I just have some minor comments on this one.

[Rohitesh-Kumar-Jain]

@slarse I would be glad if you may have again have a look at the PR : )

[slarse]

Looks good to me! Just had a minor note on the new assertion's layout. But I think this is fine to merge, if you want to fix anything up at a later time you can just come back here.

[slarse]

The new assertion strengthens the test case in the sense that it verifies that there's a nested type with name nestedClass, and that's what was requested. So I think this is fine now.

However, I just wanted to note that the layout of the assertion makes it look like a test for CtType.getNestedType(String). To be clear, it looks like the assertion verifies that getting a nested type by a given name returns a type with that name. It would be sufficient here to just verify that the returned type is non-null, due to the functionality of getNestedType.

Suggested change

	assertEquals("nestedClass", targetType.getNestedType("nestedClass").getSimpleName());
	assertNotNull(targetType.getNestedType("nestedClass"));

Personally, I would probably have written both assertions like this instead, so as not to have to query targetType multiple times.

        List<CtType<?>> nestedTypes = targetType.getNestedTypes();
        assertThat(nestedTypes.size(), equalTo(1));
        assertThat(nestedTypes.get(0), equalTo("nestedClass"));

[Rohitesh-Kumar-Jain]

Thanks for the suggestions, so I can add this in the PR that I will raise for another new test?