Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(noclasspath): Handle type resolution of anonymous class with unresolved constructor #3971

Merged

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented May 31, 2021

Fix #3913

This PR fixes a problem in resolving generic types in noclasspath mode. The symptoms are specifically evident when creating an anonymous subclass of a generic type while using a constructor that does not exist. It can probably occur elsewhere as well, but this is where it was found to be easily reproducible.

See #3913 for further details.

@slarse slarse changed the title wip: fix(noclasspath): Handle type resolution of anonymous class creation from unresolved constructor wip: fix(noclasspath): Handle type resolution of anonymous class from unresolved constructor May 31, 2021
@slarse slarse changed the title wip: fix(noclasspath): Handle type resolution of anonymous class from unresolved constructor wip: fix(noclasspath): Handle type resolution of anonymous class with unresolved constructor May 31, 2021
@slarse slarse changed the title wip: fix(noclasspath): Handle type resolution of anonymous class with unresolved constructor review: fix(noclasspath): Handle type resolution of anonymous class with unresolved constructor May 31, 2021
@monperrus monperrus changed the title review: fix(noclasspath): Handle type resolution of anonymous class with unresolved constructor fix(noclasspath): Handle type resolution of anonymous class with unresolved constructor Jun 1, 2021
@monperrus monperrus merged commit 011be63 into INRIA:master Jun 1, 2021
@monperrus
Copy link
Collaborator

Thanks @slarse for the nice one-liner.

@slarse slarse deleted the issue/3913-fix-crash-on-parsing-generic-type branch June 1, 2021 06:18
@monperrus monperrus mentioned this pull request Aug 19, 2021
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getTypeReference(TypeReference) returns unexpected result when a type has multiple parameters
2 participants