fix: Fix crash on null type binding in nested type during search #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
monperrus
changed the title
|
Thanks for the fix @slarse |
slarse
deleted the
issue/3950/3572-fix-crash-on-null-type-binding-in-nested-type
branch
|
Note that there's still a bug here (#3708). With this enhanced test case I hope to be able to actually show some symptoms of that bug, which I previously failed to do. |
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3950
Fix #3572
This PR fixes a crash that occurs when Spoon is forced to search for type bindings, and there's a duplicated type with nested types that are also duplicated. It's a very fringe thing that only occurs when running with
setIgnoreDuplicateDeclarations(true).