chore: Move Checkstyle config location into property #3910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
slarse
changed the title
monperrus
changed the title
|
Simple change, everything is green :) Thanks. |
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to make #3907 green before merging, related to #3906
This PR moves the hard-coded Checkstyle config location into the
checkstyle.config.locationproperty (default user property for the<configLocation>element). This provides a default that can be overridden from the command line by specifying-Dcheckstyle.config.location=path/to/some/checkstyle.xml. This in turn is necessary for #3906 to be able to run with all the configuration in the pom for Checkstyle, but a different Checkstyle config.