fix: Fix infinite loop on type parameter in qualified name #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
|
Nice fix! This is heavily tested, so I will merge with confidence. |
monperrus
changed the title
|
Thanks @slarse for the bug and the fix! |
|
Thanks to me for the fix, thanks to @gchaperon for reporting the bug along with an easily reproducible scenario! |
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3903
This PR fixes the infinite loop described in #3903 by assuming that any qualified name that contains a type parameter reference is fully qualified. I'm pretty sure that assumption is valid, as one can only reference a type parameter from within the class or method that defines it.
In any case, it's better than an infinite loop :)