fix: fix snippet compilation bugs #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbwogi
changed the title
andrewbwogi
changed the title
|
@andrewbwogi FYI, to trigger the CI you can just close and re-open the PR. If you require a new commit, you can push an empty commit like so: $ git commit --allow-empty -m 'Empty commit to trigger CI'
$ git push |
|
@slarse, good tip! |
andrewbwogi
changed the title
|
Thanks @andrewbwogi LGTM. Snippets were originally made only for quick pretty-printing of anything. On the fly snippet compilation was added afterwards and is indeed hard to get right in all situations. |
monperrus
changed the title
|
Thanks @andrewbwogi ! |
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3898