feat: Add CtFormalTypeDeclarer.addFormalCtTypeParameterAt #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But this fails architecture enforcer tests
algomaster99
reviewed
May 2, 2021
slarse
changed the title
slarse
changed the title
This reverts commit 90da7cb.
slarse
changed the title
monperrus
changed the title
|
Thanks a lot @slarse |
slarse
deleted the
issue/3884-CtFormalTypeDeclarer.addFormalCtTypeParameterAt
branch
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3884
This PR adds
CtFormalTypeDeclarer.addFormalCtTypeParameterAt(int, CtTypeParameter).I'm not happy with the current implementation, as the code for adding a type parameter in a specific position is duplicated across all implementations of the method. I'm trying out some ideas to reduce this code duplication.This seems to be a problem for most of theCtFormalTypeDeclarermethods. Since Java doesn't have any kind of support for mixin classes, extracting the functionality is tricky.We'll deal with the code duplication separately.
This is ready for review!Actually no it isn't saw a typo ...Ok, now it's ready for review!