Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump license-maven-plugin to version 4.0 #3887

Merged
merged 4 commits into from
Apr 27, 2021

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Apr 23, 2021

This PR does the same thing as #3868 in bumping the version of license-maven-plugin, but also fixes the errors. There are two fixes, apart from bumping the version:

  1. Wrap the configuration in the <licenseSets><licenseSet> tags, which is mandatory for version 4.0
    • We might want to look at the new features for handling multiple licenses, that's what this is for! I think that's for a different PR, though.
  2. Adopt the new default format (slashstar, header starts with /* as opposed to Javadoc /**).
    • I prefer this format, as linters such as the one in IntelliJ IDEA complain about "dangling Javadoc comment" when the Javadoc style is used for a header.

@slarse slarse changed the title chore: Bump license-maven-plugin to version 4.0 wip: chore: Bump license-maven-plugin to version 4.0 Apr 23, 2021
@slarse slarse changed the title wip: chore: Bump license-maven-plugin to version 4.0 review: chore: Bump license-maven-plugin to version 4.0 Apr 26, 2021
@monperrus
Copy link
Collaborator

LGTM, will merge!

We might want to look at the new features for handling multiple licenses, that's what this is for! I think that's for a different PR, though.

Agree.

Thanks!

@monperrus monperrus changed the title review: chore: Bump license-maven-plugin to version 4.0 chore: Bump license-maven-plugin to version 4.0 Apr 27, 2021
@monperrus monperrus merged commit 2fff4c5 into INRIA:master Apr 27, 2021
@slarse slarse deleted the update-maven-license-plugin branch April 28, 2021 06:52
@monperrus monperrus mentioned this pull request Aug 19, 2021
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants