feat: Add CtAbstractInvocation.addArgumentAt method #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
slarse
changed the title
algomaster99
added a commit
to ASSERT-KTH/diffmin
that referenced
this pull request
Apr 22, 2021
…erged Signed-off-by: Aman Sharma <[email protected]>
monperrus
changed the title
|
useful new API method! thanks @slarse |
This was referenced Apr 28, 2021
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3884
This PR adds the method
CtAbstractInvocation.addArgumentAt(int, CtExpression<?>)to the public API, as discussed in #3884.This PR will determine whether we go with the
addXnaming convention, or theaddXAtnaming convention. Both are already present in the project, but we should adopt one as the predominant style. I favoraddXAt(int,CtElement)because it makes it easier to see that the method is distinct, butaddX(int,CtElement)is also valid as that is a common overload in the Java standard library collections.