chore: Remove all traces of Travis CI #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slarse
changed the title
slarse
changed the title
slarse
changed the title
|
|
slarse
changed the title
monperrus
reviewed
Apr 19, 2021
| if [[ "$TRAVIS_REPO_SLUG" == "INRIA/spoon" ]] && [[ "$TRAVIS_PULL_REQUEST" != "false" ]] | ||
| then | ||
| echo "downloading extra CI PR script from SpoonLabs/spoon-ci-external" | ||
| curl https://raw.githubusercontent.com/SpoonLabs/spoon-ci-external/master/spoon-pull-request.sh | bash |
There was a problem hiding this comment.
we may keep that, it's cool for experimenting. How to update the if condition in GHA?
There was a problem hiding this comment.
Re-added, you can see here that the "downloading extra CI PR..." is now being executed: https://github.com/INRIA/spoon/runs/2387878660#step:8:3814
monperrus
changed the title
|
Thanks a lot @slarse |
|
Good bye @travis-ci! It was great to work with you, you helped Spoon very much over several years. |
Merged
woutersmeenk
pushed a commit
to woutersmeenk/spoon
that referenced
this pull request
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3836
This PR removes all traces of Travis CI.
Note "removes", and not "migrates". Two pieces of functionality is lost here, both executing external scripts. This adds significant complexity to the CI pipeline, without any tangible benefit.
First, the final portion
chore/ci-extra.sh, which is supposed to execute an external CI script on pull requests, is removed. It executed a script that there never appears to have contained anything. Therefore, it's hard to justify keeping that.Second, this PR also removes the
chore/travis/ci-master.shscript which contained the following line:I believe this was used to trigger the upload of surefire reports to spoon-ci-data. I'm also uncertain of the value of this functionality. It hasn't been running for 5 months, and no one seems to have missed having it. In any case, documenting its removal here so we can reimplement it if desired.
If we want these two removed pieces of functionality to be reimplemented, then #3836 is still relevant. If we don't (which I argue for, we have enough complexity with the CI as it is), then this PR concludes #3836.