Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix violations of Sonar rule 2057 #3866

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Mar 29, 2021

Hi,

This PR fixes 9 violations of Sonar Rule 2057: '"Serializable" classes should have a "serialVersionUID"'.

The patch was generated automatically with the tool Sorald. For details on the fix applied here, please see Sorald's documentation on rule 2057.

@slarse slarse changed the title WIP: fix: Fix 9 violations of Sonar rule 2057 WIP: fix: Fix violations of Sonar rule 2057 Mar 29, 2021
@slarse
Copy link
Collaborator Author

slarse commented Mar 29, 2021

The processor that enabled this fix was primarily created by @MartinWitt specifically to address this issue in the Spoon project (see #3781). To acknowledge this, please add the following co-author mention in the body of the merge commit message:

Co-authored-by: MartinWitt <[email protected]>

@slarse slarse changed the title WIP: fix: Fix violations of Sonar rule 2057 review: fix: Fix violations of Sonar rule 2057 Mar 29, 2021
@monperrus
Copy link
Collaborator

LGTM, will merge. Thanks @slarse and @MartinWitt

@monperrus monperrus changed the title review: fix: Fix violations of Sonar rule 2057 fix: Fix violations of Sonar rule 2057 Mar 30, 2021
@monperrus monperrus merged commit 8b63309 into INRIA:master Mar 30, 2021
@slarse slarse deleted the fix-2057-rule-violations branch March 30, 2021 07:34
@monperrus monperrus mentioned this pull request Aug 19, 2021
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants