Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REVIEW remove outdated instances of maven.inria.fr #3860

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

monperrus
Copy link
Collaborator

@monperrus monperrus commented Mar 25, 2021

fix #3858

see also #3216

@monperrus
Copy link
Collaborator Author

CI Failure is

Failed to execute goal on project visualisation: Could not resolve dependencies for project fr.inria.gforge.spoon:visualisation:jar:1.1: Could not find artifact io.github.interacto:interacto-javafx:jar:3.4 in ow2.org-snapshot
```

Never seen `io.github.interacto:interacto-javafx` before and don't know where it's meant to be found. @arnobl thoughts? 

@slarse
Copy link
Collaborator

slarse commented Mar 25, 2021

@monperrus I just happened to see that your comment's formatting obscured the ping to @arnobl in a code block. @arnobl see above :)

@arnobl
Copy link
Contributor

arnobl commented Mar 25, 2021

Interacto is the graphical lib used by Spoon Visualiser.
Available on maven central since the 4.0 version (see https://search.maven.org/artifact/io.github.interacto/interacto-javafx/4.3.1/jar) (was before on the inria maven repo).
The current version used by Spoon Visualiser is 3.4: this explains the issue.
I will look at that asap.

@monperrus
Copy link
Collaborator Author

monperrus commented Mar 25, 2021 via email

@slarse
Copy link
Collaborator

slarse commented Mar 25, 2021

This also addresses #3858

@monperrus monperrus changed the title remove outdated instances of maven.inria.fr REVIEW remove outdated instances of maven.inria.fr Mar 26, 2021
@monperrus
Copy link
Collaborator Author

ready to merge @surli @nharrand

Comment on lines 255 to 262
<repositories>
<repository>
<id>mavenInriaSnapshot</id>
<name>http://maven.inria.fr-snapshots</name>
<url>http://maven.inria.fr/artifactory/malai-public-snapshot</url>
<id>spoon-snapshot</id>
<name>Maven Repository for Spoon Snapshots</name>
<url>https://repository.ow2.org/nexus/content/repositories/snapshots/</url>
<snapshots><enabled>true</enabled></snapshots>
<releases><enabled>false</enabled></releases>
</repository>
Copy link
Collaborator

@slarse slarse Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my latest musings over in #3216, I don't think there is any reason to declare the snapshot repository in any of our pom files, other than for distribution management. Or if the Spoon subproject depends on a snapshot of some other Spoon project, which is the case for spoon-smpl, but no other projects at this time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my latest musings over in #3216, I don't think there is any reason to declare the snapshot repository in any of our pom files, other than for distribution management

Correct. Yet, we can proceed here, before finalizing #3216. So I'd suggest to merge this one, which does remove all instances of maven.inria.fr (the initial intention).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that seems reasonable.

@monperrus
Copy link
Collaborator Author

ping for merge @surli @nharrand

@surli surli merged commit a1cd93c into INRIA:master Mar 30, 2021
@monperrus
Copy link
Collaborator Author

thanks @surli

@monperrus monperrus mentioned this pull request Aug 19, 2021
woutersmeenk pushed a commit to woutersmeenk/spoon that referenced this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc/bug: doc/faq.md refers to the maven.inria.fr snapshot repo
4 participants