Sets the parent in insertBefore/After and refactors these methods. #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool! since you change the test file, it's impossible to see the new test case and assertion that you are fixing. |
The formatting of this file was really (!) bad. Some test cases used tabs, other used spaces and even both sometimes. And I renamed the file. But I didn't change any test, just add new assertions on existing tests and create new tests. |
|
I can imagine. It's better to split the PR in two, one for the bug fix (with a clear Might be two commits in the same PR. |
| parentStatementList.getStatements().add(i, s); | ||
| } | ||
|
|
||
| new InsertBeforeVisitor(target, statements, InsertType.AFTER).scan(e); |
There was a problem hiding this comment.
Change name to InsertVisitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345