fix: fix non terminating PositionBuilder #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWitt
reviewed
Sep 14, 2020
| @@ -424,6 +426,13 @@ public void testPositionGeneric() throws Exception { | |||
| assertEquals("protected static", contentAtPosition(classContent, position3.getModifierSourceStart(), position3.getModifierSourceEnd())); | |||
| } | |||
|
|
|||
| @Test(timeout=10000) | |||
There was a problem hiding this comment.
is there a reason for the timeout?
There was a problem hiding this comment.
The test specifically tests to make sure PositionBuilder terminates in a reasonable time. The existing bug caused non-termination, therefore if it doesn't terminate in a reasonable time, we assume it to be non-terminating
|
LGTM, all tests are green, will merge. |
monperrus
changed the title
|
Thanks a lot @Strum355 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PositionBuilder would get caught in the
<in the annotation string, resulting ino2==o1and no advancement being made.This fix ignores the opening angle bracket if it comes at the start of the search space