fix: intersection types with wildcard "?" are allowed as simplename #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWitt
changed the title
MartinWitt
changed the title
monperrus
changed the title
|
Thanks a lot @MartinWitt! |
A refactoring PR to unify this is more than welcome :-) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes intersectiontypes set simplename for a typereference to "?". We should allow this. Sadly we are cutting more and more corners in this check, because we have 1 check for all
setSimplenamemethods. Now spoon would acceptint a? =3;, which isn't problematic for analyzing code, but for transformations. More problematic is that we have at least 2 implementations for the identifier check, see here. But maybe we should continue step by step fixing the issue and after that find a solution for the problem described above.