Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix handling of intersection types for lambda parameters #3521

Merged
merged 6 commits into from
Aug 17, 2020
Merged

fix: fix handling of intersection types for lambda parameters #3521

merged 6 commits into from
Aug 17, 2020

Conversation

quentinLeDilavrec
Copy link
Contributor

monperrus
monperrus reviewed Aug 8, 2020
View reviewed changes
Copy link
Collaborator

@monperrus monperrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution! See review comments :)

src/main/java/spoon/support/reflect/code/CtLambdaImpl.java Outdated
if (!(lambdaTypeRef instanceof CtIntersectionTypeReference)) {
return getOverriddenAux(lambdaTypeRef);
} else {
CtElement parent = lambdaTypeRef.getParent();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor the else block in getOverriddenMethodForIntersectionType?

src/main/java/spoon/support/reflect/code/CtLambdaImpl.java Show resolved Hide resolved
src/test/java/spoon/test/lambda/LambdaTest.java Show resolved Hide resolved
monperrus
monperrus reviewed Aug 15, 2020
View reviewed changes
Copy link
Collaborator

@monperrus monperrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the update. Last thing: could you rename getOverriddenAux into getOverriddenMethodForNormalType? Thanks!

@quentinLeDilavrec
rename auxilary
b4a8b40 
from getOverriddenMethodAux
to getOverriddenMethodForIntersectionType
@monperrus
Copy link
Collaborator

Thanks. We have a few checkstyle problems.

@nharrand
Copy link
Collaborator

LGTM! @monperrus do you want to merge?

@monperrus monperrus changed the title Lambda intersection with cast fix: fix handling of intersection types for lambda parameters Aug 17, 2020
@monperrus monperrus merged commit f8e0c69 into INRIA:master Aug 17, 2020
@monperrus
Copy link
Collaborator

Yes, thanks a lot @quentinLeDilavrec and @nharrand for the polishing commit!

@spoon-bot spoon-bot mentioned this pull request Aug 18, 2020
Closed
@monperrus monperrus mentioned this pull request Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monperrus monperrus monperrus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quentinLeDilavrec @monperrus @nharrand