refactor: introduce ModificationStatus for better readability #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWitt
reviewed
Jun 6, 2020
| @@ -133,29 +133,29 @@ protected void printSpaces(int fragmentIndex) { | |||
| * false if whole `fragment` is not modified. | |||
| * null if it is not possible to detect it here. Then it will be detected later. | |||
There was a problem hiding this comment.
update comment, null value is not returned anymore?
MartinWitt
reviewed
Jun 6, 2020
Comment on lines
+23
to
+30
| public boolean toBoolean() { | ||
| if (this == MODIFIED) { | ||
| return true; | ||
| } | ||
| if (this == NOT_MODIFIED) { | ||
| return false; | ||
| } | ||
| throw new IllegalStateException(); |
There was a problem hiding this comment.
shouldn't this be abstract and all Enum constants implement this? Otherwise every new enum item would need a change in this method.
There was a problem hiding this comment.
that's not necessary to over-engineer, this enum is very unlikely to change
MartinWitt
reviewed
Jun 6, 2020
| @@ -69,10 +69,10 @@ public boolean knowsHowToPrint(PrinterEvent event) { | |||
| } | |||
|
|
|||
| @Override | |||
| protected Boolean isFragmentModified(SourceFragment fragment) { | |||
| protected ModificationStatus isFragmentModified(SourceFragment fragment) { | |||
| //we cannot fast detect if it is modified using our changeResolver. | |||
| //So return null. The code later will detect it including modified roles. | |||
There was a problem hiding this comment.
update comment, null value is not returned anymore?
|
|
@nharrand ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.