fix: Fix issue #3052

[Egor18]

Fix #3052.
Here is why this bug is happening:
Eclipse jdt tells us that the binding of the listener variable inside the lambda is null in noclasspath mode,
so we run createVariableAccessNoClasspath(), it calls getVariableDeclaration(), which uses classFactory.create() for inner classes improperly. This leads to the creation of a new top-level class Failing (with unknown position), so references get messed up and we get this new class with no position instead of the original Failing.

More specifically the problem was that the description of the classFactory.create() said that it can handle both . and $, but its implementation handles only $, so I added getNormalQualifiedName() and fixed context builder. By the way, it's not possible to handle them both in classFactory.create(), since . is used as a package separator and $ as an inner type separator and we need to distinguish between the two of them.

[monperrus]

That's great! thanks a lot @Egor18

@aveuiller would you make a try and confirm that it fixes your problem before we merge to master?

[aveuiller]

I tried it out and the fix is working. Thanks for the quick reaction !

Do you know when you will to release a patch version with this fix?

[monperrus]

Do you know when you will to release a patch version with this fix?

When #3057 is merged.

[monperrus]

Should be released now :-)

[aveuiller]

I confirm, and it's working perfectly. Thanks!