fix: fix Problems with javadoc parameters @exception and others #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
reviewed
Jun 24, 2019
| @@ -50,7 +50,7 @@ | |||
| private String keyword; | |||
|
|
|||
| boolean hasName() { | |||
| return this == PARAM || this == THROWS; | |||
| return this == PARAM || this == THROWS || this == EXCEPTION; | |||
There was a problem hiding this comment.
we have code duplication here. What about refactoring to have a single implementation?
There was a problem hiding this comment.
Yes, I've just been writing about it. It would be useful for #3033 issue too.
added 2 commits
June 24, 2019 21:07
|
Thanks a lot for the refactoring. In Spoon, we are super careful with backward compatibility (unless it's in an "internal" package), what do you think of moving code of new |
|
Sure, you're right. |
|
Cool, thanks! |
monperrus
changed the title
Egor18
changed the title
monperrus
changed the title
|
Thanks a lot Egor. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3033
fix #3034