Add literal base #3014
Merged
Add literal base #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nharrand
reviewed
Jun 8, 2019
|
Well done, esp. since you had to understand all the internals when adding a new role :-) LGTM, ok to merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2396
This PR adds base (2, 8, 10 or 16) to the numeric CtLiterals. Pretty printer will also output literals according to their base.
Note: I'd like to set the return value of
getBase()toOptional<LiteralBase>instead of nullableLiteralBase, but the API test does not like it since it wants to see the actual getter. I can fix it if you want because I think thatOptionalmakes more sense here since only numeric literals can have a base and having null for other literals is a bit unintuitive.