fix NPE with duplicate inner class #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reproduced the NPE, thanks for the failing test case, it's very valuable. Looking at it. |
monperrus
changed the title
|
The fix was easy: protect against null. JDT is very inconsistent, and in some cases, some fields are null. Since we have no control over this, JDTTreeBuilder is full of defensive checks. |
nice! thanks! |
|
Thanks a lot for the contribution! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is decompilation of the bytecode file, but as I understand parser should never throw exception when it tries to build AST. I would prefer if it would just skip the second class, if it's possible. Or maybe you prefer another way for it? Thanks.
stacktrace:
java.lang.NullPointerException
at spoon.support.compiler.jdt.JDTTreeBuilderHelper.createType(JDTTreeBuilderHelper.java:623)
at spoon.support.compiler.jdt.JDTTreeBuilder.visit(JDTTreeBuilder.java:1663)
at org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.traverse(TypeDeclaration.java:1485)