Fixes file resource leak #1521
Merged
Fixes file resource leak #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap the output streams for the generated files inside a try-with-resources.
|
Thank You @tiagodrcarvalho for fix of this little, but critical problem! The file resource leaks are really not good ;-) |
|
Hi @pvojtechovsky. I'm glad you accepted my fix! We use spoon in a peculiar way (in a more "low-level" approach in which we work directly with the AST) and a feature we added in our work required a second execution of spoon (in the same Java execution) over the generated code, which lead to this resource leak (after some debugging). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap the output streams for the generated files inside a try-with-resources. Was preventing generated files from being deleted/moved while Spoon was still executing.