Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Substitution#createTypeFromTemplate return type #1464

Merged
merged 3 commits into from
Jul 5, 2017

Conversation

pvojtechovsky
Copy link
Collaborator

It can be used without need to cast return value now.

@spoon-bot
Copy link
Collaborator

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.8.0-20170704.224553-91

New API: fr.inria.gforge.spoon:spoon-core:jar:5.8.0-SNAPSHOT

Detected changes: 1.

Change 1

Name Element
Old method spoon.reflect.declaration.CtType spoon.template.Substitution::createTypeFromTemplate(java.lang.String, spoon.reflect.declaration.CtType, java.util.Map<java.lang.String, java.lang.Object>)
New method <T extends spoon.reflect.declaration.CtType> T spoon.template.Substitution::createTypeFromTemplate(java.lang.String, spoon.reflect.declaration.CtType, java.util.Map<java.lang.String, java.lang.Object>)
Code java.method.returnTypeTypeParametersChanged
Description The return type changed from 'spoon.reflect.declaration.CtType' to 'T extends spoon.reflect.declaration.CtType<?>'.
Breaking binary: non_breaking

Change 1

Name Element
Old method spoon.reflect.declaration.CtType spoon.template.Substitution::createTypeFromTemplate(java.lang.String, spoon.reflect.declaration.CtType, java.util.Map<java.lang.String, java.lang.Object>)
New method <T extends spoon.reflect.declaration.CtType> T spoon.template.Substitution::createTypeFromTemplate(java.lang.String, spoon.reflect.declaration.CtType, java.util.Map<java.lang.String, java.lang.Object>)
Code java.generics.formalTypeParameterChanged
Description The formal type parameter changed from 'T' to 'T extends spoon.reflect.declaration.CtType<?>'.
Breaking binary: non_breaking

@spoon-bot
Copy link
Collaborator

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.8.0-20170704.224553-91

New API: fr.inria.gforge.spoon:spoon-core:jar:5.8.0-SNAPSHOT

Detected changes: 1.

Change 1

Name Element
Old method spoon.reflect.declaration.CtType spoon.template.Substitution::createTypeFromTemplate(java.lang.String, spoon.reflect.declaration.CtType, java.util.Map<java.lang.String, java.lang.Object>)
New method <T extends spoon.reflect.declaration.CtType> T spoon.template.Substitution::createTypeFromTemplate(java.lang.String, spoon.reflect.declaration.CtType, java.util.Map<java.lang.String, java.lang.Object>)
Code java.method.returnTypeTypeParametersChanged
Description The return type changed from 'spoon.reflect.declaration.CtType' to 'T extends spoon.reflect.declaration.CtType<?>'.
Breaking binary: non_breaking

Change 1

Name Element
Old method spoon.reflect.declaration.CtType spoon.template.Substitution::createTypeFromTemplate(java.lang.String, spoon.reflect.declaration.CtType, java.util.Map<java.lang.String, java.lang.Object>)
New method <T extends spoon.reflect.declaration.CtType> T spoon.template.Substitution::createTypeFromTemplate(java.lang.String, spoon.reflect.declaration.CtType, java.util.Map<java.lang.String, java.lang.Object>)
Code java.generics.formalTypeParameterChanged
Description The formal type parameter changed from 'T' to 'T extends spoon.reflect.declaration.CtType<?>'.
Breaking binary: non_breaking

@monperrus monperrus merged commit 494c2bb into INRIA:master Jul 5, 2017
@pvojtechovsky pvojtechovsky deleted the fixCreateTypeReturnType branch October 5, 2017 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants