-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature CtQuery#filterChildren(null) #1140
Conversation
What is the problem? I do not know how to fix it. |
There is one more problem when Filter is used in existing So you have to write Filter filter = new ...;
element.map(new ParameterScopeQuery)
.map(e->filter.matches(e))
.failurePolicy(QueryFailurePolicy.IGNORE)... Do you still like it? I vote for one of these methods
Note: we cannot implement Or any other solution - if somebody has one. |
super atomic PR, thanks. Would you add one line of Javadoc in filterChildren to document the contract? |
which is the default behavior we want, because it's very explicit at runtime, right? |
right. We want to throw CCE on standard mapping functions, because otherwise it is very hard to found "Why my query does not work and returns nothing..." |
Done from my point of view |
rebase? |
f408ef4
to
6ef2db8
Compare
Done. |
Support for calling filterChildren without filter. It returns all visited elements.