chore: prepares checkstyle checking for src/test/java (#2611)

* up

* Commit by Martin Monperrus on 09 October 2018

checkstyle-test.xml

@@ -0,0 +1,21 @@
+<?xml version="1.0"?>
+<!--  Checkstyle config for Spoon tests -->
+<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
+<module name="Checker">
+  <module name="NewlineAtEndOfFile">
+    <property name="lineSeparator" value="lf"/>
+  </module>
+  <!-- Trailing spaces -->
+<!--  <module name="RegexpSingleline">
+    <property name="format" value="\s+$"/>
+    <property name="message" value="Line has trailing spaces."/>
+  </module>-->
+
+  <!-- Checks for the new line format -->
+<!--  <module name="RegexpMultiline">
+    <property name="format" value="\r\n"/>
+    <property name="message" value="Do not use Windows line endings"/>
+  </module>-->
+
+<!-- our new rules, only for src/test/java   -->
+</module>

chore/travis/travis-verify.sh

@@ -4,7 +4,18 @@
 # it runs verify and site maven goals
 # and to check documentation links
 
+# fails if anything fails
+set -e
+
 source /opt/jdk_switcher/jdk_switcher.sh
+
 pip install --user CommonMark==0.7.5 requests pygithub
 
-jdk_switcher use oraclejdk9 && mvn -Djava.src.version=1.9 verify license:check site javadoc:jar install -DskipTests -DadditionalJOption=-Xdoclint:none && python ./chore/check-links-in-doc.py
+jdk_switcher use oraclejdk9
+
+mvn -Djava.src.version=1.9 verify license:check site javadoc:jar install -DskipTests -DadditionalJOption=-Xdoclint:none
+
+# checkstyle in src/tests
+mvn  checkstyle:checkstyle -Pcheckstyle-test
+
+python ./chore/check-links-in-doc.py

pom.xml

@@ -660,7 +660,24 @@
   </reporting>
 
   <profiles>
-    <profile>
+      <profile>
+          <id>checkstyle-test</id>
+          <build>
+              <plugins>
+                  <plugin>
+                      <groupId>org.apache.maven.plugins</groupId>
+                      <artifactId>maven-checkstyle-plugin</artifactId>
+                      <version>2.17</version>
+                      <configuration>
+                          <failsOnError>true</failsOnError>
+                          <configLocation>checkstyle-test.xml</configLocation>
+                          <consoleOutput>true</consoleOutput>
+                      </configuration>
+                  </plugin>
+              </plugins>
+          </build>
+      </profile>
+      <profile>
       <id>coveralls</id>
       <build>
         <plugins>