fix(CtCase): add fix for missing parents (#3695)

INRIA · Nov 14, 2020 · c970571 · c970571
1 parent 55bdd96
commit c970571
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/main/java/spoon/support/reflect/code/CtCaseImpl.java b/src/main/java/spoon/support/reflect/code/CtCaseImpl.java
@@ -93,6 +93,7 @@ public <T extends CtCase<E>> T addCaseExpression(CtExpression<E> caseExpression)
 			setCaseExpression(caseExpression);
 		}
 		getFactory().getEnvironment().getModelChangeListener().onObjectUpdate(this, CtRole.CASE, caseExpressions, this.caseExpressions);
+		caseExpression.setParent(this);
 		this.caseExpressions.add(caseExpression);
 		return (T) this;
 	}

diff --git a/src/test/java/spoon/test/model/SwitchCaseTest.java b/src/test/java/spoon/test/model/SwitchCaseTest.java
@@ -112,6 +112,17 @@ public void testSwitchStatementOnAString() throws Exception {
 				assertEquals(String.class.getName(), aCase.getCaseExpression().getType().getTypeDeclaration().getQualifiedName());
 			}
 		}
+		@DisplayName("Parent is set")
+		@Test
+		public void testParentInCaseExpressions() {
+				// contract: for all expressions in a case, the parent is set.
+				Launcher launcher = new Launcher();
+				launcher.getEnvironment().setComplianceLevel(14);
+				launcher.addInputResource(new VirtualFile("class A { { int x = switch(1) { case 1, 3 -> 0; default -> 1}; } }"));
+				launcher.buildModel();
+				List<CtLiteral<?>> caseStatement = launcher.getModel().getElements(new TypeFilter<>(CtLiteral.class));
+				assertTrue(caseStatement.stream().allMatch(CtLiteral::isParentInitialized));
+		}
 	}