Add xml id's when merging if missing

INL · Oct 15, 2024 · 02760a7 · 02760a7
1 parent 0736f1b
commit 02760a7
Show file tree

Hide file tree

Showing 5 changed files with 462 additions and 455 deletions.
diff --git a/server/src/main/kotlin/org/ivdnt/galahad/port/tei/export/TEITextMerger.kt b/server/src/main/kotlin/org/ivdnt/galahad/port/tei/export/TEITextMerger.kt
@@ -238,6 +238,7 @@ open class TEITextMerger(
         }
         // Both <w> and <pc> have a pos.
         wTag.setAttribute(posType(), termToAdd.posOrEmpty)
+        wTag.setAttribute("xml:id", termToAdd.targets.first().id)
         return wTag
     }
 
@@ -307,6 +308,10 @@ open class TEITextMerger(
         }
         element.setAttribute(posType(), termToAdd.posOrEmpty)
         element.removeAttribute("type") // Update legacy formats to TEI p5
+        // First check if the element has an id already, else add it.
+        if (element.getAttribute("xml:id").isNullOrBlank()) {
+            element.setAttribute("xml:id", termToAdd.targets.first().id)
+        }
     }
 
     private fun getWordFormsToAdd(): List<WordForm> {

diff --git a/server/src/test/kotlin/org/ivdnt/galahad/port/tei/TEIExportTest.kt b/server/src/test/kotlin/org/ivdnt/galahad/port/tei/TEIExportTest.kt
@@ -35,6 +35,7 @@ internal class TEIExportTest {
             .ignoreTrailingWhiteSpaces()
             .ignoreDate()
             .ignoreUUID()
+            .ignoreWhiteSpaceDocumentWide()
             .result()
     }
 
@@ -52,6 +53,7 @@ internal class TEIExportTest {
             .mergeTEI(Resource.get("tei/brieven/input.tei.xml"), layer)
             .ignoreDate()
             .ignoreUUID()
+            .ignoreWhiteSpaceDocumentWide()
             .result()
     }